+Build/work/release.cpp:31:2: warning: preprocessor condition is always 'false', consider removing both the condition and its contents [readability-avoid-unconditional-preprocessor-if] +Build/work/release.cpp:35:2: warning: preprocessor condition is always 'false', consider removing both the condition and its contents [readability-avoid-unconditional-preprocessor-if] -innoextract/src/cli/extract.cpp:142:68: warning: parameter name 'f' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:146:67: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:170:24: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:197:31: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:200:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:202:4: warning: variable 'sign' of type 'util::fstream::off_type' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:205:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:245:31: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:248:17: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:251:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:256:16: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/extract.cpp:257:4: warning: variable 'n' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:257:20: warning: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:258:29: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:259:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:283:47: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:294:7: warning: function 'match' has cognitive complexity of 31 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:342:2: warning: variable 'is_temp' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:347:2: warning: variable 'is_temp' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:373:14: warning: function 'handle_collision' has cognitive complexity of 44 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:380:3: warning: variable 'version_info_valid' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:432:27: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:452:2: warning: variable 'pos' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:464:2: warning: variable 'internal_dir' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:472:3: warning: variable 'existing' of type 'std::pair' (aka 'pair, (anonymous namespace)::processed_directory> *, false>, bool>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:489:6: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/cli/extract.cpp:497:2: warning: variable 'oldlength' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:506:3: warning: variable 'inserted' of type 'DirectoriesMap::iterator' (aka 'vec_iterator, (anonymous namespace)::processed_directory> *, false>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:516:47: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:548:9: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:549:2: warning: variable 'suffix' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:554:3: warning: variable 'insertion' of type 'std::pair' (aka 'pair, (anonymous namespace)::processed_file>, void *>, boost::unordered::detail::bucket, (anonymous namespace)::processed_file>, void *>, void *>>, bool>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:571:6: warning: function 'rename_collisions' has cognitive complexity of 85 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:571:48: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:591:3: warning: variable 'ignore_component' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:605:6: warning: function 'print_file_info' has cognitive complexity of 124 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:605:46: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:631:2: warning: variable 'multiple_sections' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:662:3: warning: variable 'id' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:662:15: warning: variable name 'id' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:711:8: warning: accessing fields in struct 'processed_entries' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/cli/extract.cpp:719:19: warning: function 'filter_entries' has cognitive complexity of 194 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:719:58: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:729:34: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:729:50: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:734:2: warning: variable 'includes' of type 'path_filter' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:755:3: warning: variable 'internal_path' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:757:3: warning: variable 'path_included' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:761:28: warning: variable name 'it' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:763:4: warning: variable 'existing' of type 'std::pair' (aka 'pair, (anonymous namespace)::processed_directory> *, false>, bool>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:800:3: warning: variable 'internal_path' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:802:3: warning: variable 'path_included' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:810:3: warning: variable 'insertion' of type 'std::pair' (aka 'pair, (anonymous namespace)::processed_file>, void *>, boost::unordered::detail::bucket, (anonymous namespace)::processed_file>, void *>, void *>>, bool>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:820:6: warning: do not use 'else' after 'throw' [readability-else-after-return] -innoextract/src/cli/extract.cpp:829:6: warning: variable 'oldlang' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:830:6: warning: variable 'newlang' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:879:54: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:893:6: warning: function 'process_file' has cognitive complexity of 826 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/extract.cpp:893:71: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:895:7: warning: variable 'is_directory' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/cli/extract.cpp:916:2: warning: uninitialized record type: 'offsets' [cppcoreguidelines-pro-type-member-init] -innoextract/src/cli/extract.cpp:982:6: warning: do not use 'else' after 'throw' [readability-else-after-return] -innoextract/src/cli/extract.cpp:999:2: warning: variable 'multiple_sections' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1066:5: warning: variable 'dir' of type 'fs::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1088:18: warning: variable 'location' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1100:19: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:1113:4: warning: variable 'location' of type 'setup::data_entry &' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1124:4: warning: variable 'dir' of type 'fs::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1170:5: warning: static member accessed through instance [readability-static-accessed-through-instance] -innoextract/src/cli/extract.cpp:1230:9: warning: variable 'size' of type 'boost::uint64_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1242:5: warning: variable 'updated' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1262:4: warning: uninitialized record type: 'checksum' [cppcoreguidelines-pro-type-member-init] -innoextract/src/cli/extract.cpp:1282:7: warning: variable 'it' of type 'multi_part_outputs::iterator' (aka 'ptr_map_iterator<_Rb_tree_iterator>, const (anonymous namespace)::processed_file *, (anonymous namespace)::file_output *const>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1282:36: warning: variable name 'it' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:1310:17: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/extract.cpp:1310:24: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/extract.cpp:1311:5: warning: variable 'buffer_size' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1311:35: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:1312:5: warning: variable 'n' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1312:21: warning: variable name 'n' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/extract.cpp:1315:7: warning: variable 'success' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1315:44: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:1320:30: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:1321:21: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/extract.cpp:1344:6: warning: variable 'output_checksum' of type 'crypto::checksum' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/extract.cpp:1390:2: warning: static member accessed through instance [readability-static-accessed-through-instance] -innoextract/src/cli/extract.hpp:38:8: warning: accessing fields in struct 'format_error' is inefficient due to padding; only needs 1 bytes but is using 16 bytes [altera-struct-pack-align] -innoextract/src/cli/extract.hpp:38:8: warning: accessing fields in struct 'format_error' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 1 bytes [altera-struct-pack-align] -innoextract/src/cli/extract.hpp:49:8: warning: accessing fields in struct 'extract_options' is inefficient due to padding; only needs 236 bytes but is using 248 bytes [altera-struct-pack-align] -innoextract/src/cli/extract.hpp:49:8: warning: accessing fields in struct 'extract_options' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/cli/extract.hpp:94:2: warning: constructor does not initialize these fields: codepage [cppcoreguidelines-pro-type-member-init] -innoextract/src/cli/extract.hpp:120:86: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:59:13: warning: function 'get_game_id' has cognitive complexity of 30 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/gog.cpp:61:14: warning: variable name 'id' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:64:2: warning: variable 'prefix_length' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:93:46: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:105:23: warning: variable 'quit_requested' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/cli/gog.cpp:110:75: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:190:74: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:192:2: warning: variable 'dir' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:230:2: warning: variable 'ret' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:242:73: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:246:19: warning: parameter name 'c' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:247:9: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/gog.cpp:248:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:249:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/cli/gog.cpp:250:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:250:26: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/gog.cpp:254:7: warning: class 'temporary_directory' defines a non-default destructor but does not define a copy constructor or a copy assignment operator [cppcoreguidelines-special-member-functions] -innoextract/src/cli/gog.cpp:298:6: warning: function 'process_rar_files' has cognitive complexity of 81 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/gog.cpp:299:48: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:311:13: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/gog.cpp:313:19: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/cli/gog.cpp:314:25: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/cli/gog.cpp:315:35: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:315:61: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/gog.cpp:316:35: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:316:61: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/gog.cpp:324:8: warning: variable name 'ok' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:358:4: warning: variable 'here' of type 'fs::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:365:11: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:371:5: warning: variable 'symlink' of type 'fs::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:397:3: warning: the value returned by this function should be used [cert-err33-c] -innoextract/src/cli/gog.cpp:400:3: warning: the value returned by this function should be used [cert-err33-c] -innoextract/src/cli/gog.cpp:403:3: warning: the value returned by this function should be used [cert-err33-c] -innoextract/src/cli/gog.cpp:415:85: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:424:22: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:433:4: warning: uninitialized record type: 'offsets' [cppcoreguidelines-pro-type-member-init] -innoextract/src/cli/gog.cpp:452:54: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:453:60: warning: 2 adjacent parameters of 'probe_bin_file_series' of similar type ('size_t') are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/cli/gog.cpp:498:6: warning: function 'probe_bin_files' has cognitive complexity of 36 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/gog.cpp:498:46: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/gog.cpp:501:2: warning: variable 'dir' of type 'boost::filesystem::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:502:2: warning: variable 'basename' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/gog.cpp:520:11: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.cpp:527:11: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/gog.hpp:43:46: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/goggalaxy.cpp:45:26: warning: function 'parse_function_call' has cognitive complexity of 43 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/goggalaxy.cpp:55:2: warning: variable 'start' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:60:2: warning: variable 'end' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:65:2: warning: variable 'parenthesis' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:74:9: warning: variable name 'p' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/goggalaxy.cpp:88:5: warning: variable 'string_end' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:103:4: warning: variable 'token_end' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:120:5: warning: do not use 'else' after 'break' [readability-else-after-return] -innoextract/src/cli/goggalaxy.cpp:142:20: warning: parameter name 'c' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/goggalaxy.cpp:145:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/cli/goggalaxy.cpp:145:34: warning: repeated branch body in conditional chain [bugprone-branch-clone] -innoextract/src/cli/goggalaxy.cpp:146:20: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/goggalaxy.cpp:148:20: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/goggalaxy.cpp:156:2: warning: uninitialized record type: 'checksum' [cppcoreguidelines-pro-type-member-init] -innoextract/src/cli/goggalaxy.cpp:159:24: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/goggalaxy.cpp:165:24: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/cli/goggalaxy.cpp:166:3: warning: variable 'a' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:166:7: warning: variable name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/goggalaxy.cpp:167:3: warning: variable 'b' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/goggalaxy.cpp:167:7: warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/goggalaxy.cpp:172:21: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/cli/goggalaxy.cpp:178:8: warning: accessing fields in struct 'constraint' is inefficient due to padding; only needs 33 bytes but is using 40 bytes [altera-struct-pack-align] -innoextract/src/cli/goggalaxy.cpp:178:8: warning: accessing fields in struct 'constraint' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 64 bytes [altera-struct-pack-align] -innoextract/src/cli/goggalaxy.cpp:251:6: warning: function 'parse_galaxy_files' has cognitive complexity of 460 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/goggalaxy.cpp:336:6: warning: variable 'compressed_size' of type 'boost::uint64_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:55:21: warning: function 'get_command' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/cli/main.cpp:65:2: warning: variable 'pos' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:73:21: warning: function is not thread safe [concurrency-mt-unsafe] -innoextract/src/cli/main.cpp:76:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/cli/main.cpp:81:13: warning: function 'print_version' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/cli/main.cpp:81:51: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:98:13: warning: function 'print_help' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/cli/main.cpp:113:13: warning: function 'print_license' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/cli/main.cpp:122:5: warning: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape] -innoextract/src/cli/main.cpp:122:5: warning: function 'main' has cognitive complexity of 127 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/cli/main.cpp:173:26: warning: variable name 'io' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:196:37: warning: variable name 'p' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:213:20: warning: variable name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:228:20: warning: variable 'color_e' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/cli/main.cpp:229:2: warning: variable 'color_i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:235:20: warning: variable 'progress_e' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/cli/main.cpp:236:2: warning: variable 'progress_i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:259:2: warning: variable 'explicit_list' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:272:2: warning: variable 'explicit_action' of type 'bool' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:294:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:294:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:296:4: warning: variable 'timezone_name' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:317:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:317:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:322:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:322:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:324:4: warning: variable 'collisions' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:340:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:340:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:348:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:348:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:355:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:355:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:370:3: warning: variable 'i' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:370:37: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:384:3: warning: variable 'password' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:385:3: warning: variable 'password_file' of type 'po::variables_map::const_iterator' (aka '_Rb_tree_const_iterator, boost::program_options::variable_value>>') can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:394:19: warning: variable name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/cli/main.cpp:395:4: warning: variable 'file' of type 'fs::path' can be declared 'const' [misc-const-correctness] -innoextract/src/cli/main.cpp:479:18: warning: variable name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/adler32.cpp:32:23: warning: variable name 's1' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/adler32.cpp:32:28: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:33:23: warning: variable name 's2' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/adler32.cpp:33:28: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:33:53: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:35:14: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:38:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:41:20: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:52:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:53:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:54:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:55:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:56:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:57:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:57:29: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:58:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:58:29: warning: 6 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:59:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:59:29: warning: 7 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:61:13: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:62:11: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:68:15: warning: 0x8000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:73:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/adler32.cpp:73:35: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/adler32.cpp:73:41: warning: C-style casts are discouraged; use static_cast [google-readability-casting] +innoextract/src/crypto/arc4.cpp:25:1: warning: included header endian.hpp is not used directly [misc-include-cleaner] +innoextract/src/crypto/arc4.cpp:29:35: warning: no header providing "size_t" is directly included [misc-include-cleaner] -innoextract/src/crypto/checksum.cpp:50:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/crypto/checksum.cpp:50:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/crypto/checksum.cpp:50:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/crypto/checksum.cpp:58:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/checksum.cpp:60:2: warning: variable 'old_fmtflags' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/checksum.cpp:70:40: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/checksum.cpp:74:40: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/checksum.cpp:78:26: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/crypto/checksum.cpp:79:60: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/checksum.cpp:79:64: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/checksum.cpp:84:26: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/crypto/checksum.cpp:85:60: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/checksum.cpp:85:64: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/checksum.hpp:49:8: warning: accessing fields in struct 'checksum' is inefficient due to poor alignment; currently aligned to 4 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/crypto/checksum.hpp:54:12: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/checksum.hpp:55:13: warning: 20 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/checksum.hpp:75:24: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/checksum.hpp:77:19: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/checksum.hpp:77:19: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/crypto/checksum.hpp:87:24: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/checksum.hpp:95:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/crypto/checksum.hpp:95:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/crypto/checksum.hpp:97:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/crc32.cpp:86:23: warning: function 'crc32_index' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/crypto/crc32.cpp:87:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/crc32.cpp:87:30: warning: 0xff is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/crc32.cpp:90:24: warning: function 'crc32_shifted' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/crypto/crc32.cpp:91:16: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/crc32.cpp:96:9: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/crypto/crc32.cpp:97:40: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/crc32.cpp:111:40: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/hasher.cpp:25:1: warning: constructor does not initialize these fields: adler32, crc32, md5, sha1 [cppcoreguidelines-pro-type-member-init] -innoextract/src/crypto/hasher.cpp:51:2: warning: uninitialized record type: 'result' [cppcoreguidelines-pro-type-member-init] -innoextract/src/crypto/iteratedhash.hpp:67:24: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/iteratedhash.hpp:81:2: warning: variable 'old_count_lo' of type 'hash_word' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/iteratedhash.hpp:83:15: warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition] -innoextract/src/crypto/iteratedhash.hpp:83:32: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:87:14: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:87:47: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/iteratedhash.hpp:89:2: warning: variable 'num' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/iteratedhash.hpp:89:50: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:89:50: warning: redundant cast to the same type [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:106:3: warning: variable 'left_over' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/iteratedhash.hpp:135:44: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:150:28: warning: 2 adjacent parameters of 'pad' of convertible types are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/crypto/iteratedhash.hpp:152:46: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:152:46: warning: redundant cast to the same type [google-readability-casting] -innoextract/src/crypto/iteratedhash.hpp:168:2: warning: variable 'order' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/iteratedhash.hpp:170:2: warning: variable 'size' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/crypto/md5.cpp:32:13: warning: 0x67452301l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/md5.cpp:33:13: warning: 0xefcdab89l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/md5.cpp:34:13: warning: 0x98badcfel is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/md5.cpp:35:13: warning: 0x10325476l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/md5.cpp:40:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:40:28: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:40:33: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:40:37: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:42:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:42:27: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:42:31: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:43:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:43:28: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:43:33: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:46:24: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:46:41: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/md5.cpp:48:2: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration] -innoextract/src/crypto/md5.cpp:48:12: warning: variable 'a' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/crypto/md5.cpp:48:12: warning: variable name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/md5.cpp:48:15: warning: variable 'b' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/crypto/md5.cpp:48:15: warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/md5.cpp:48:18: warning: variable 'c' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/crypto/md5.cpp:48:18: warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/md5.cpp:48:21: warning: variable 'd' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/crypto/md5.cpp:48:21: warning: variable name 'd' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:31:13: warning: 0x67452301l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:32:13: warning: 0xefcdab89l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:33:13: warning: 0x98badcfel is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:34:13: warning: 0x10325476l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:35:13: warning: 0xc3d2e1f0l is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:41:21: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:41:51: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:41:70: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:42:53: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:42:70: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:44:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:44:28: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:44:33: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:44:37: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:45:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:45:27: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:45:31: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:46:24: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:46:28: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:46:34: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:46:39: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:46:43: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:47:23: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:47:27: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:47:31: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:52:3: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:55:3: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:58:3: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:61:3: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:64:3: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] -innoextract/src/crypto/sha1.cpp:66:12: warning: variable name 'W' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:66:14: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/crypto/sha1.cpp:69:12: warning: variable name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:70:12: warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:71:12: warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:72:12: warning: variable name 'd' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/crypto/sha1.cpp:73:12: warning: variable name 'e' is too short, expected at least 3 characters [readability-identifier-length] +innoextract/src/loader/exereader.cpp:23:1: warning: included header iomanip is not used directly [misc-include-cleaner] +innoextract/src/loader/exereader.cpp:26:1: warning: included header algorithm is not used directly [misc-include-cleaner] +innoextract/src/loader/exereader.cpp:39:6: warning: enum 'BinaryType' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint16_t' (2 bytes) as the base type to reduce its size [performance-enum-size] -innoextract/src/loader/exereader.cpp:73:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/loader/exereader.cpp:87:13: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/loader/exereader.cpp:108:66: warning: 2 adjacent parameters of 'find_resource' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters] +innoextract/src/loader/exereader.cpp:108:66: warning: 2 adjacent parameters of 'find_resource' of similar type ('boost::uint32_t') are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/loader/offsets.cpp:43:8: warning: accessing fields in struct 'setup_loader_version' is inefficient due to poor alignment; currently aligned to 4 bytes, but recommended alignment is 16 bytes [altera-struct-pack-align] -innoextract/src/loader/offsets.cpp:45:22: warning: 12 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/loader/offsets.cpp:69:49: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.cpp:73:2: warning: variable 'magic' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/loader/offsets.cpp:83:2: warning: variable 'offset_table_offset' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/loader/offsets.cpp:84:2: warning: variable 'not_offset_table_offset' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/loader/offsets.cpp:97:53: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.cpp:112:46: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.cpp:120:13: warning: 12 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/loader/offsets.cpp:121:20: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/loader/offsets.cpp:128:24: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/loader/offsets.cpp:141:2: warning: uninitialized record type: 'checksum' [cppcoreguidelines-pro-type-member-init] -innoextract/src/loader/offsets.cpp:146:3: warning: variable 'revision' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/loader/offsets.cpp:151:5: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/loader/offsets.cpp:191:3: warning: variable 'expected' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/loader/offsets.cpp:205:35: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.hpp:51:8: warning: accessing fields in struct 'offsets' is inefficient due to padding; only needs 49 bytes but is using 52 bytes [altera-struct-pack-align] -innoextract/src/loader/offsets.hpp:51:8: warning: accessing fields in struct 'offsets' is inefficient due to poor alignment; currently aligned to 4 bytes, but recommended alignment is 64 bytes [altera-struct-pack-align] -innoextract/src/loader/offsets.hpp:123:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.hpp:127:41: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.hpp:129:45: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/loader/offsets.hpp:131:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.cpp:57:43: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.cpp:57:60: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.cpp:109:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/component.cpp:109:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/component.cpp:109:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/component.hpp:42:8: warning: accessing fields in struct 'component_entry' is inefficient due to padding; only needs 253 bytes but is using 256 bytes [altera-struct-pack-align] -innoextract/src/setup/component.hpp:42:8: warning: accessing fields in struct 'component_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/component.hpp:42:8: warning: constructor does not initialize these fields: extra_disk_pace_required, level, used, winver, size [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/component.hpp:71:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.hpp:71:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.hpp:77:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.hpp:77:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/component.hpp:77:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/component.hpp:77:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/data.cpp:35:18: warning: function 'load' has cognitive complexity of 42 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/setup/data.cpp:35:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.cpp:35:55: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.cpp:66:31: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/data.cpp:69:30: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/data.cpp:79:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:83:3: warning: variable 'time' of type 'boost::uint16_t' (aka 'unsigned short') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/data.cpp:84:3: warning: variable 'date' of type 'boost::uint16_t' (aka 'unsigned short') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/data.cpp:86:3: warning: uninitialized record type: 't' [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/data.cpp:86:13: warning: variable name 't' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.cpp:89:37: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:89:40: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:90:36: warning: 11 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:90:40: warning: 15 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:92:37: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:92:41: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:93:37: warning: 9 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:93:40: warning: 15 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:93:46: warning: 1980 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:93:53: warning: 1900 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:110:26: warning: 10000000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:111:20: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/data.cpp:111:47: warning: 10000000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:111:59: warning: 100 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:115:2: warning: variable 'file_version_ms' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/data.cpp:116:2: warning: variable 'file_version_ls' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/data.cpp:117:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/data.cpp:117:54: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/data.cpp:118:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/data.cpp:195:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/data.cpp:195:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/data.cpp:195:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/data.hpp:44:8: warning: accessing fields in struct 'data_entry' is inefficient due to padding; only needs 116 bytes but is using 120 bytes [altera-struct-pack-align] -innoextract/src/setup/data.hpp:44:8: warning: accessing fields in struct 'data_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/data.hpp:44:8: warning: constructor does not initialize these fields: chunk, file, uncompressed_size, timestamp, timestamp_nsec, file_version [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/data.hpp:82:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.hpp:82:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.hpp:88:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.hpp:88:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/data.hpp:88:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/data.hpp:88:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/delete.cpp:40:40: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/delete.cpp:40:57: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/delete.cpp:57:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/delete.cpp:57:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/delete.cpp:57:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/delete.hpp:39:8: warning: accessing fields in struct 'delete_entry' is inefficient due to padding; only needs 36 bytes but is using 296 bytes [altera-struct-pack-align] -innoextract/src/setup/delete.hpp:39:8: warning: accessing fields in struct 'delete_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 64 bytes [altera-struct-pack-align] -innoextract/src/setup/delete.hpp:39:8: warning: constructor does not initialize these fields: type [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/delete.hpp:51:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/delete.hpp:51:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/delete.hpp:57:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/delete.hpp:57:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/directory.cpp:49:43: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.cpp:49:60: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.cpp:76:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/directory.cpp:81:32: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/directory.cpp:84:59: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/directory.cpp:91:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/directory.cpp:91:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/directory.cpp:91:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/directory.hpp:42:8: warning: accessing fields in struct 'directory_entry' is inefficient due to padding; only needs 78 bytes but is using 336 bytes [altera-struct-pack-align] -innoextract/src/setup/directory.hpp:42:8: warning: accessing fields in struct 'directory_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/directory.hpp:42:8: warning: constructor does not initialize these fields: attributes, permission [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/directory.hpp:61:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.hpp:61:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.hpp:67:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.hpp:67:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/directory.hpp:67:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/directory.hpp:67:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] +innoextract/src/setup/expression.cpp:25:1: warning: included header vector is not used directly [misc-include-cleaner] +innoextract/src/setup/expression.cpp:44:13: warning: no header providing "std::string" is directly included [misc-include-cleaner] +innoextract/src/setup/expression.cpp:47:7: warning: enum 'token_type' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size] -innoextract/src/setup/file.cpp:63:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:63:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:65:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/file.cpp:65:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:65:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:74:18: warning: function 'load' has cognitive complexity of 34 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/setup/file.cpp:74:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.cpp:74:55: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.cpp:103:3: warning: variable 'copyMode' of type 'file_copy_mode' can be declared 'const' [misc-const-correctness] -innoextract/src/setup/file.cpp:115:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/file.cpp:124:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/file.cpp:195:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/file.cpp:209:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/file.cpp:209:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:209:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:245:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/file.cpp:245:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.cpp:245:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.hpp:44:8: warning: accessing fields in struct 'file_entry' is inefficient due to padding; only needs 214 bytes but is using 480 bytes [altera-struct-pack-align] -innoextract/src/setup/file.hpp:44:8: warning: accessing fields in struct 'file_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/file.hpp:44:8: warning: constructor does not initialize these fields: location, attributes, external_size, permission, type, checksum, size [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/file.hpp:116:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.hpp:116:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.hpp:122:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.hpp:122:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/file.hpp:122:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.hpp:122:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.hpp:123:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/file.hpp:123:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] +innoextract/src/setup/filename.cpp:56:6: warning: no header providing "std::string" is directly included [misc-include-cleaner] +innoextract/src/setup/filename.cpp:66:7: warning: no header providing "std::map" is directly included [misc-include-cleaner] -innoextract/src/setup/header.cpp:146:14: warning: function 'load' has cognitive complexity of 211 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/setup/header.cpp:146:34: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.cpp:375:25: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:378:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:382:24: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/header.cpp:383:11: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer] -innoextract/src/setup/header.cpp:383:30: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:425:3: warning: variable 'code_line_offset' of type 'boost::int32_t' (aka 'int') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/header.cpp:430:3: warning: variable 'val' of type 'auto_bool' can be declared 'const' [misc-const-correctness] -innoextract/src/setup/header.cpp:548:23: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/header.cpp:688:24: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:689:12: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer] -innoextract/src/setup/header.cpp:693:23: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:694:12: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer] -innoextract/src/setup/header.cpp:698:22: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/header.cpp:699:12: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer] -innoextract/src/setup/header.cpp:743:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:743:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:743:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:807:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:807:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:807:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:815:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:815:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:815:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:820:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:820:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:820:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:826:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:826:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:826:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:832:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:832:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:832:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:838:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:838:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:838:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:843:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:843:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:843:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:849:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:849:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:849:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:856:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/header.cpp:856:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.cpp:856:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:47:19: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/header.hpp:49:8: warning: accessing fields in struct 'header' is inefficient due to padding; only needs 1568 bytes but is using 1576 bytes [altera-struct-pack-align] -innoextract/src/setup/header.hpp:49:8: warning: accessing fields in struct 'header' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/header.hpp:49:8: warning: constructor does not initialize these fields: language_count, message_count, permission_count, type_count, component_count, task_count, directory_count, file_count, data_entry_count, icon_count, ini_entry_count, registry_entry_count, delete_entry_count, uninstall_delete_entry_count, run_entry_count, uninstall_run_entry_count, winver, back_color, back_color2, image_back_color, small_image_back_color, wizard_style, wizard_resize_percent_x, wizard_resize_percent_y, image_alpha_format, password, extra_disk_space_required, slices_per_disk, install_mode, uninstall_log_mode, uninstall_style, dir_exists_warning, privileges_required, show_language_dialog, language_detection, compression, signed_uninstaller_original_size, signed_uninstaller_header_checksum, disable_dir_page, disable_program_group_page, uninstall_display_size [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/header.hpp:174:14: warning: 256 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/header.hpp:280:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:288:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:288:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:288:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:288:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:289:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:289:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:289:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:289:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:290:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:290:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/header.hpp:290:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:290:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:291:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:291:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:292:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:292:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:293:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:293:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:294:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:294:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:295:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:295:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:296:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:296:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:297:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/header.hpp:297:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.cpp:40:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.cpp:40:55: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.cpp:64:11: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer] -innoextract/src/setup/icon.cpp:64:53: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/icon.cpp:97:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/icon.cpp:118:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/icon.cpp:118:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.cpp:118:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.cpp:128:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/icon.cpp:128:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.cpp:128:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.hpp:42:8: warning: accessing fields in struct 'icon_entry' is inefficient due to padding; only needs 278 bytes but is using 536 bytes [altera-struct-pack-align] -innoextract/src/setup/icon.hpp:42:8: warning: accessing fields in struct 'icon_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/icon.hpp:42:8: warning: constructor does not initialize these fields: icon_index, show_command, close_on_exit, hotkey [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/icon.hpp:81:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.hpp:81:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.hpp:87:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.hpp:87:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/icon.hpp:87:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.hpp:87:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.hpp:88:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/icon.hpp:88:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/info.cpp:53:40: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:72:40: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:96:50: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:133:51: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:135:7: warning: variable 'dummy' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/setup/info.cpp:143:12: warning: function 'try_load' has cognitive complexity of 55 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/setup/info.cpp:143:36: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:236:12: warning: function 'load' has cognitive complexity of 27 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/setup/info.cpp:236:32: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.cpp:262:2: warning: variable 'start' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/info.cpp:289:4: warning: variable 'next_version' of type 'version_constant' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/info.hpp:57:8: warning: accessing fields in struct 'info' is inefficient due to padding; only needs 2100 bytes but is using 2104 bytes [altera-struct-pack-align] -innoextract/src/setup/info.hpp:57:8: warning: accessing fields in struct 'info' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/info.hpp:57:8: warning: class 'info' defines a destructor but does not define a copy constructor or a copy assignment operator [cppcoreguidelines-special-member-functions] -innoextract/src/setup/info.hpp:57:8: warning: class 'info' defines a non-default destructor but does not define a copy constructor or a copy assignment operator [cppcoreguidelines-special-member-functions] -innoextract/src/setup/info.hpp:133:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.hpp:150:31: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.hpp:153:35: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.hpp:160:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/info.hpp:160:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.cpp:44:37: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.cpp:44:54: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.cpp:62:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/ini.cpp:65:44: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/ini.cpp:71:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/ini.cpp:71:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/ini.cpp:71:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/ini.hpp:40:8: warning: accessing fields in struct 'ini_entry' is inefficient due to padding; only needs 136 bytes but is using 392 bytes [altera-struct-pack-align] -innoextract/src/setup/ini.hpp:40:8: warning: accessing fields in struct 'ini_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/ini.hpp:57:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.hpp:57:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.hpp:63:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.hpp:63:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/ini.hpp:63:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/ini.hpp:63:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/item.cpp:29:47: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/item.cpp:29:64: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/item.hpp:39:8: warning: accessing fields in struct 'item' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 256 bytes [altera-struct-pack-align] -innoextract/src/setup/item.hpp:39:8: warning: constructor does not initialize these fields: winver [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/item.hpp:53:42: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/item.hpp:53:59: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/item.hpp:55:40: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.cpp:36:8: warning: accessing fields in struct 'windows_language' is inefficient due to poor alignment; currently aligned to 2 bytes, but recommended alignment is 4 bytes [altera-struct-pack-align] -innoextract/src/setup/language.cpp:123:42: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.cpp:123:59: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.cpp:198:47: warning: parameter name 'cp' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.hpp:40:8: warning: accessing fields in struct 'language_entry' is inefficient due to padding; only needs 369 bytes but is using 376 bytes [altera-struct-pack-align] -innoextract/src/setup/language.hpp:40:8: warning: accessing fields in struct 'language_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/language.hpp:40:8: warning: constructor does not initialize these fields: language_id, codepage, dialog_font_size, dialog_font_standard_height, title_font_size, welcome_font_size, copyright_font_size, right_to_left [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/language.hpp:65:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.hpp:65:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/language.hpp:67:32: warning: parameter name 'cp' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/message.cpp:34:41: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/message.cpp:34:58: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/message.cpp:41:18: warning: variable 'codepage' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/setup/message.cpp:44:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/message.cpp:51:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/message.hpp:36:8: warning: accessing fields in struct 'message_entry' is inefficient due to padding; only needs 68 bytes but is using 72 bytes [altera-struct-pack-align] -innoextract/src/setup/message.hpp:36:8: warning: accessing fields in struct 'message_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/message.hpp:36:8: warning: constructor does not initialize these fields: language [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/message.hpp:49:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/message.hpp:49:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] +innoextract/src/setup/permission.cpp:27:34: warning: no header providing "std::istream" is directly included [misc-include-cleaner] -innoextract/src/setup/registry.cpp:62:42: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.cpp:62:59: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.cpp:69:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/registry.cpp:86:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/registry.cpp:87:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/setup/registry.cpp:87:55: warning: 0x80000000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/registry.cpp:100:32: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/registry.cpp:108:25: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/setup/registry.cpp:138:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/registry.cpp:138:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.cpp:138:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.cpp:153:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/registry.cpp:153:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.cpp:153:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.cpp:164:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/registry.cpp:164:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.cpp:164:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:41:8: warning: accessing fields in struct 'registry_entry' is inefficient due to padding; only needs 148 bytes but is using 408 bytes [altera-struct-pack-align] -innoextract/src/setup/registry.hpp:41:8: warning: accessing fields in struct 'registry_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/registry.hpp:41:8: warning: constructor does not initialize these fields: hive, permission, type [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/registry.hpp:93:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.hpp:93:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.hpp:99:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.hpp:99:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/registry.hpp:99:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:99:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:100:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:100:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:101:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/registry.hpp:101:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.cpp:42:37: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.cpp:42:54: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.cpp:115:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/run.cpp:115:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.cpp:115:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.cpp:128:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/run.cpp:128:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.cpp:128:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.hpp:40:8: warning: accessing fields in struct 'run_entry' is inefficient due to padding; only needs 240 bytes but is using 496 bytes [altera-struct-pack-align] -innoextract/src/setup/run.hpp:40:8: warning: accessing fields in struct 'run_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/run.hpp:40:8: warning: constructor does not initialize these fields: show_command, wait [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/run.hpp:76:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.hpp:76:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.hpp:82:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.hpp:82:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/run.hpp:82:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.hpp:82:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.hpp:83:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/run.hpp:83:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/task.cpp:32:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.cpp:32:55: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.cpp:80:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/task.cpp:80:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/task.cpp:80:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/task.hpp:40:8: warning: accessing fields in struct 'task_entry' is inefficient due to padding; only needs 269 bytes but is using 272 bytes [altera-struct-pack-align] -innoextract/src/setup/task.hpp:40:8: warning: accessing fields in struct 'task_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/task.hpp:40:8: warning: constructor does not initialize these fields: level, used, winver [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/task.hpp:66:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.hpp:66:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.hpp:72:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.hpp:72:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/task.hpp:72:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/task.hpp:72:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:51:1: warning: parameter name 'a' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.cpp:51:1: warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.cpp:51:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:51:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:55:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.cpp:55:55: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.cpp:74:2: warning: variable 'options' of type 'type_flags' (aka 'flags') can be declared 'const' [misc-const-correctness] -innoextract/src/setup/type.cpp:92:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/type.cpp:92:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:92:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:96:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/setup/type.cpp:96:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.cpp:96:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.hpp:42:8: warning: accessing fields in struct 'type_entry' is inefficient due to padding; only needs 205 bytes but is using 208 bytes [altera-struct-pack-align] -innoextract/src/setup/type.hpp:42:8: warning: accessing fields in struct 'type_entry' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 128 bytes [altera-struct-pack-align] -innoextract/src/setup/type.hpp:42:8: warning: constructor does not initialize these fields: winver, custom_type, type, size [cppcoreguidelines-pro-type-member-init] -innoextract/src/setup/type.hpp:66:27: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.hpp:66:44: warning: parameter name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/setup/type.hpp:72:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/setup/type.hpp:72:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] +innoextract/src/setup/version.cpp:28:1: warning: included header version.hpp is not used directly [misc-include-cleaner] +innoextract/src/setup/version.cpp:30:1: warning: included header lexical_cast.hpp is not used directly [misc-include-cleaner] +innoextract/src/setup/version.cpp:31:1: warning: included header string.hpp is not used directly [misc-include-cleaner] +innoextract/src/setup/version.cpp:219:31: warning: no header providing "std::streamsize" is directly included [misc-include-cleaner] +innoextract/src/setup/version.cpp:249:8: warning: no header providing "std::string" is directly included [misc-include-cleaner] +innoextract/src/setup/version.cpp:256:24: warning: no header providing "boost::bad_lexical_cast" is directly included [misc-include-cleaner] +innoextract/src/setup/version.cpp:285:13: warning: no header providing "boost::contains" is directly included [misc-include-cleaner] +innoextract/src/setup/version.hpp:51:2: warning: enum 'flags_Enum_' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size] +innoextract/src/setup/windows.cpp:35:39: warning: no header providing "std::istream" is directly included [misc-include-cleaner] +innoextract/src/setup/windows.cpp:107:2: warning: no header providing "size_t" is directly included [misc-include-cleaner] +innoextract/src/setup/windows.cpp:121:9: warning: no header providing "NULL" is directly included [misc-include-cleaner] -innoextract/src/stream/block.cpp:85:3: warning: variable 'temp_size' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:85:31: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:86:3: warning: variable 'nread' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:89:5: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/stream/block.cpp:89:13: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:92:3: warning: variable 'block_crc32' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:94:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:94:55: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:95:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:99:3: warning: uninitialized record type: 'actual' [cppcoreguidelines-pro-type-member-init] -innoextract/src/stream/block.cpp:121:4: warning: variable 'size' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:121:39: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:125:11: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:135:14: warning: 4096 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/block.cpp:143:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/block.cpp:143:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/block.cpp:145:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/stream/block.cpp:145:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/block.cpp:145:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/block.cpp:157:2: warning: variable 'expected_checksum' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:158:2: warning: uninitialized record type: 'actual_checksum' [cppcoreguidelines-pro-type-member-init] -innoextract/src/stream/block.cpp:161:18: warning: variable 'stored_size' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/stream/block.cpp:162:20: warning: variable 'compression' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/stream/block.cpp:167:3: warning: variable 'compressed' of type 'boost::uint8_t' (aka 'unsigned char') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:173:3: warning: variable 'compressed_size' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:174:3: warning: variable 'uncompressed_size' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/block.cpp:176:25: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:183:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/block.cpp:183:78: warning: 4096 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/block.cpp:196:49: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/block.cpp:198:52: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/block.cpp:205:33: warning: 4096 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/block.hpp:42:8: warning: accessing fields in struct 'block_error' is inefficient due to padding; only needs 1 bytes but is using 32 bytes [altera-struct-pack-align] -innoextract/src/stream/block.hpp:42:8: warning: accessing fields in struct 'block_error' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 1 bytes [altera-struct-pack-align] -innoextract/src/stream/checksum.hpp:66:3: warning: variable 'nread' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/checksum.hpp:69:24: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/chunk.cpp:67:2: warning: constructor does not initialize these fields: arc4 [cppcoreguidelines-pro-type-member-init] -innoextract/src/stream/chunk.cpp:70:16: warning: 1000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:77:3: warning: variable 'length' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/chunk.cpp:79:27: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/chunk.cpp:95:37: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/chunk.cpp:99:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/stream/chunk.cpp:112:38: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/chunk.cpp:135:54: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:136:55: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:138:56: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:139:56: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:150:13: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:151:22: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:151:28: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:159:3: warning: variable 'key_length' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/chunk.cpp:160:59: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/chunk.cpp:174:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/stream/chunk.cpp:174:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.cpp:174:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.cpp:183:1: warning: initialization of 'count' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp] -innoextract/src/stream/chunk.cpp:183:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.cpp:183:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.hpp:48:8: warning: accessing fields in struct 'chunk_error' is inefficient due to padding; only needs 1 bytes but is using 32 bytes [altera-struct-pack-align] -innoextract/src/stream/chunk.hpp:48:8: warning: accessing fields in struct 'chunk_error' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 1 bytes [altera-struct-pack-align] -innoextract/src/stream/chunk.hpp:78:8: warning: accessing fields in struct 'chunk' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/stream/chunk.hpp:91:31: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/chunk.hpp:92:32: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/chunk.hpp:129:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.hpp:129:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.hpp:131:1: warning: variable 'name' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/chunk.hpp:131:1: warning: variable 'names' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/stream/exefilter.hpp:59:2: warning: constructor does not initialize these fields: addr, addr_bytes_left, addr_offset [cppcoreguidelines-pro-type-member-init] -innoextract/src/stream/exefilter.hpp:67:48: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:99:2: warning: constructor does not initialize these fields: offset, flush_bytes [cppcoreguidelines-pro-type-member-init] -innoextract/src/stream/exefilter.hpp:133:13: warning: member 'flip_high_byte' of type 'const bool' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/exefilter.hpp:156:15: warning: 0xe8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:156:31: warning: 0xe9 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:162:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:163:11: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:164:13: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:168:13: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:168:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:175:40: warning: function 'read' has cognitive complexity of 65 (threshold 25) [readability-function-cognitive-complexity] -innoextract/src/stream/exefilter.hpp:206:4: warning: variable 'byte' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/stream/exefilter.hpp:209:14: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:211:15: warning: 0xe8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:211:31: warning: 0xe9 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:217:25: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:229:3: warning: variable 'nread' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/exefilter.hpp:234:17: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:234:63: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:238:40: warning: 0xff is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:240:4: warning: variable 'addr' of type 'boost::uint32_t' (aka 'unsigned int') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/exefilter.hpp:240:36: warning: 0xffffff is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:242:39: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:242:69: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:243:39: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:243:69: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:245:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:246:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:246:38: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:247:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/exefilter.hpp:247:38: warning: 16 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:254:14: warning: 0x800000 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/exefilter.hpp:255:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/file.cpp:34:43: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/file.cpp:38:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/stream/file.cpp:47:36: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/file.cpp:60:41: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/file.cpp:64:71: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/file.cpp:69:77: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/file.cpp:70:82: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/file.cpp:71:81: warning: 8192 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/file.hpp:53:8: warning: accessing fields in struct 'file' is inefficient due to padding; only needs 44 bytes but is using 48 bytes [altera-struct-pack-align] -innoextract/src/stream/file.hpp:53:8: warning: accessing fields in struct 'file' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 64 bytes [altera-struct-pack-align] -innoextract/src/stream/file.hpp:62:30: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/file.hpp:63:31: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] +innoextract/src/stream/lzma.cpp:28:1: warning: included header load.hpp is not used directly [misc-include-cleaner] +innoextract/src/stream/lzma.cpp:34:24: warning: no header providing "NULL" is directly included [misc-include-cleaner] +innoextract/src/stream/lzma.cpp:57:19: warning: no header providing "size_t" is directly included [misc-include-cleaner] -innoextract/src/stream/restrict.hpp:38:7: warning: class 'restricted_source' defines a copy constructor but does not define a destructor or a copy assignment operator [cppcoreguidelines-special-member-functions] -innoextract/src/stream/restrict.hpp:40:18: warning: member 'base' of type 'BaseSource &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/restrict.hpp:40:18: warning: member 'base' of type 'boost::iostreams::chain &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/restrict.hpp:40:18: warning: member 'base' of type 'stream::slice_reader &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/restrict.hpp:45:46: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/stream/restrict.hpp:58:11: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/restrict.hpp:58:11: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/stream/restrict.hpp:58:36: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/restrict.hpp:63:3: warning: variable 'nread' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/restrict.hpp:67:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:52:2: warning: variable 'max_size' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:54:2: warning: variable 'file_size' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:56:15: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:98:2: warning: variable 'file_size' of type 'std::streampos' (aka 'fpos<__mbstate_t>') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:101:13: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/slice.cpp:102:21: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/slice.cpp:108:40: warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/stream/slice.cpp:122:4: warning: do not use 'else' after 'throw' [readability-else-after-return] -innoextract/src/stream/slice.cpp:150:3: warning: variable 'major' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:151:3: warning: variable 'minor' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:152:19: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:152:24: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:162:2: warning: variable 'end' of type 'boost::filesystem::directory_iterator' can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:164:3: warning: variable 'actual_filename' of type 'path_type' (aka 'boost::filesystem::path') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:179:2: warning: variable 'slice_file' of type 'path_type' (aka 'boost::filesystem::path') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:184:2: warning: variable 'slice_file2' of type 'path_type' (aka 'boost::filesystem::path') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.cpp:205:25: warning: 2 adjacent parameters of 'seek' of convertible types are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/stream/slice.cpp:230:30: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:237:15: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:244:37: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:244:65: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:245:29: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:246:23: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/stream/slice.cpp:250:3: warning: variable 'read' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/stream/slice.hpp:40:8: warning: accessing fields in struct 'slice_error' is inefficient due to padding; only needs 1 bytes but is using 32 bytes [altera-struct-pack-align] -innoextract/src/stream/slice.hpp:40:8: warning: accessing fields in struct 'slice_error' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 1 bytes [altera-struct-pack-align] -innoextract/src/stream/slice.hpp:62:24: warning: member 'data_offset' of type 'const boost::uint32_t' (aka 'const unsigned int') is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/slice.hpp:68:15: warning: member 'slices_per_disk' of type 'const size_t' (aka 'const unsigned long') is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/stream/slice.hpp:149:9: warning: method 'slice' can be made const [readability-make-member-function-const] -innoextract/src/util/align.hpp:52:40: warning: parameter name 'p' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/align.hpp:54:55: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/util/align.hpp:55:40: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/util/align.hpp:60:30: warning: parameter name 'p' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/boostfs_compat.hpp:40:1: warning: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type] -innoextract/src/util/console.cpp:48:13: warning: variable 'show_progress' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:48:13: warning: variable 'show_progress' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:53:12: warning: variable 'screen_width' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:53:12: warning: variable 'screen_width' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:56:30: warning: variable 'screen_resized' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:56:30: warning: variable 'screen_resized' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:58:13: warning: function 'sigwinch_handler' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:61:2: warning: the value returned by this function should be used [cert-err33-c] -innoextract/src/util/console.cpp:68:15: warning: variable 'black' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:69:15: warning: variable 'red' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:70:15: warning: variable 'green' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:71:15: warning: variable 'yellow' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:72:15: warning: variable 'blue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:73:15: warning: variable 'magenta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:74:15: warning: variable 'cyan' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:75:15: warning: variable 'white' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:77:15: warning: variable 'dim_black' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:78:15: warning: variable 'dim_red' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:79:15: warning: variable 'dim_green' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:80:15: warning: variable 'dim_yellow' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:81:15: warning: variable 'dim_blue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:82:15: warning: variable 'dim_magenta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:83:15: warning: variable 'dim_cyan' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:84:15: warning: variable 'dim_white' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:86:15: warning: variable 'reset' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:88:15: warning: variable 'current' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:90:11: warning: 2 adjacent parameters of 'init' of similar type ('is_enabled') are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/util/console.cpp:92:7: warning: variable 'is_tty' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/util/console.cpp:103:17: warning: function is not thread safe [concurrency-mt-unsafe] -innoextract/src/util/console.cpp:126:60: warning: function is not thread safe [concurrency-mt-unsafe] -innoextract/src/util/console.cpp:161:12: warning: function 'query_screen_width' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:174:2: warning: uninitialized record type: 'w' [cppcoreguidelines-pro-type-member-init] -innoextract/src/util/console.cpp:174:17: warning: variable name 'w' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/console.cpp:175:5: warning: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg] -innoextract/src/util/console.cpp:183:20: warning: function is not thread safe [concurrency-mt-unsafe] -innoextract/src/util/console.cpp:191:9: warning: 80 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:195:12: warning: function 'get_screen_width' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:212:13: warning: variable 'progress_cleared' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] -innoextract/src/util/console.cpp:212:13: warning: variable 'progress_cleared' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.cpp:274:2: warning: variable 'width' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:276:2: warning: variable 'flags' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:278:2: warning: variable 'progress_length' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:278:32: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:278:54: warning: 6 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:280:23: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:282:3: warning: variable 'progress' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:282:21: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:282:38: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:289:32: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:297:25: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:297:40: warning: 100 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:313:2: warning: variable 'width' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:315:2: warning: variable 'flags' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:317:2: warning: variable 'progress_length' of type 'int' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:317:32: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:317:62: warning: 6 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:319:23: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:321:3: warning: variable 'progress' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:321:30: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:321:47: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:322:21: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:329:32: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:361:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:361:42: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:362:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:362:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:362:25: warning: 1000.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:362:52: warning: 1000.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:368:18: warning: variable 'time' is not initialized [cppcoreguidelines-init-variables] -innoextract/src/util/console.cpp:370:3: warning: variable 'now' of type 'boost::posix_time::ptime' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:371:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:390:22: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:390:43: warning: 5000000.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:390:55: warning: 2.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:392:13: warning: 2.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:397:15: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:397:15: warning: performing an implicit widening conversion to type 'boost::uint64_t' (aka 'unsigned long') of a multiplication performed in type 'int' [bugprone-implicit-widening-of-multiplication-result] -innoextract/src/util/console.cpp:397:20: warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:398:4: warning: variable 'rate' of type 'float' can be declared 'const' [misc-const-correctness] -innoextract/src/util/console.cpp:398:17: warning: 1000000.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.cpp:398:29: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:398:44: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/console.cpp:402:73: warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/console.hpp:47:22: warning: variable 'reset' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:49:22: warning: variable 'black' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:50:22: warning: variable 'red' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:51:22: warning: variable 'green' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:52:22: warning: variable 'yellow' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:53:22: warning: variable 'blue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:54:22: warning: variable 'magenta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:55:22: warning: variable 'cyan' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:56:22: warning: variable 'white' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:58:22: warning: variable 'dim_black' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:59:22: warning: variable 'dim_red' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:60:22: warning: variable 'dim_green' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:61:22: warning: variable 'dim_yellow' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:62:22: warning: variable 'dim_blue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:63:22: warning: variable 'dim_magenta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:64:22: warning: variable 'dim_cyan' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:65:22: warning: variable 'dim_white' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:68:22: warning: variable 'current' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/console.hpp:70:49: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/console.hpp:120:2: warning: constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] +innoextract/src/util/encoding.cpp:56:1: warning: included header iterator is not used directly [misc-include-cleaner] +innoextract/src/util/encoding.cpp:58:1: warning: included header vector is not used directly [misc-include-cleaner] +innoextract/src/util/encoding.cpp:73:1: warning: included header unordered_map.hpp is not used directly [misc-include-cleaner] +innoextract/src/util/encoding.cpp:238:26: warning: no header providing "std::string" is directly included [misc-include-cleaner] -innoextract/src/util/encoding.cpp:327:21: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:337:46: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:341:34: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:341:47: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:345:47: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:349:58: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:349:71: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:353:48: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:357:63: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/encoding.cpp:357:76: warning: C-style casts are discouraged; use static_cast [google-readability-casting] +innoextract/src/util/encoding.cpp:522:2: warning: return statement within a void function should not have a specified return value [readability-avoid-return-with-void-value] +innoextract/src/util/encoding.cpp:599:16: warning: no header providing "boost::unordered_map" is directly included [misc-include-cleaner] -innoextract/src/util/encoding.cpp:655:31: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast] +innoextract/src/util/encoding.cpp:655:31: warning: do not use const_cast to remove const qualifier [cppcoreguidelines-pro-type-const-cast] +innoextract/src/util/encoding.cpp:787:25: warning: no header providing "std::bitset" is directly included [misc-include-cleaner] +innoextract/src/util/encoding.hpp:36:6: warning: enum 'known_codepages' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint16_t' (2 bytes) as the base type to reduce its size [performance-enum-size] +innoextract/src/util/endian.hpp:110:8: warning: the implicit default constructor of the CRTP is publicly accessible; consider making it private and declaring the derived class as friend [bugprone-crtp-constructor-accessibility] -innoextract/src/util/endian.hpp:238:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/endian.hpp:238:12: warning: redundant cast to the same type [google-readability-casting] -innoextract/src/util/endian.hpp:238:23: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/endian.hpp:246:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/endian.hpp:267:12: warning: redundant cast to the same type [google-readability-casting] -innoextract/src/util/endian.hpp:267:22: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/endian.hpp:275:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names>' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names>' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names>' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names>' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names>' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:48:8: warning: accessing fields in struct 'enum_names' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 32 bytes [altera-struct-pack-align] -innoextract/src/util/enum.hpp:50:15: warning: member 'count' of type 'const size_t' (aka 'const unsigned long') is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/enum.hpp:87:27: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/enum.hpp:88:14: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/enum.hpp:89:3: warning: variable 'i' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness] -innoextract/src/util/enum.hpp:89:10: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/enum.hpp:89:14: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/enum.hpp:94:30: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/enum.hpp:98:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/enum.hpp:99:2: warning: variable 'prev' of type 'color::shell_command' can be declared 'const' [misc-const-correctness] -innoextract/src/util/enum.hpp:113:4: warning: do not use 'else' after 'return' [readability-else-after-return] +innoextract/src/util/flags.hpp:64:17: warning: function 'flags' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier] -innoextract/src/util/flags.hpp:64:66: warning: C-style casts are discouraged; use static_cast [google-readability-casting] +innoextract/src/util/flags.hpp:66:17: warning: function 'flags' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier] +innoextract/src/util/load.cpp:29:31: warning: no header providing "std::istream" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:29:50: warning: no header providing "std::string" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:41:24: warning: no header providing "std::streamsize" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:57:68: warning: no header providing "util::codepage_id" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:58:38: warning: no header providing "std::bitset" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:60:2: warning: no header providing "util::to_utf8" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:63:42: warning: no header providing "size_t" is directly included [misc-include-cleaner] +innoextract/src/util/load.cpp:64:5: warning: no header providing "BOOST_VERSION" is directly included [misc-include-cleaner] -innoextract/src/util/load.hpp:151:18: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:212:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:213:12: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/load.hpp:214:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:215:2: warning: variable 'mask' of type 'UT' (aka 'unsigned short') can be declared 'const' [misc-const-correctness] -innoextract/src/util/load.hpp:215:12: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:215:46: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:215:54: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:215:57: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/load.hpp:216:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/log.cpp:27:14: warning: variable 'debug' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.cpp:28:14: warning: variable 'quiet' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.cpp:30:16: warning: variable 'total_errors' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.cpp:31:16: warning: variable 'total_warnings' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.cpp:35:2: warning: variable 'previous' of type 'color::shell_command' can be declared 'const' [misc-const-correctness] -innoextract/src/util/log.hpp:51:7: warning: class 'logger' defines a non-default destructor but does not define a copy constructor or a copy assignment operator [cppcoreguidelines-special-member-functions] -innoextract/src/util/log.hpp:64:18: warning: member 'level' of type 'const log_level' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/log.hpp:70:16: warning: variable 'total_warnings' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.hpp:71:16: warning: variable 'total_errors' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.hpp:73:14: warning: variable 'debug' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] -innoextract/src/util/log.hpp:74:14: warning: variable 'quiet' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables] +innoextract/src/util/log.hpp:55:7: warning: enum 'log_level' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size] -innoextract/src/util/math.hpp:38:25: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/math.hpp:50:9: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/math.hpp:50:9: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/math.hpp:101:9: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:39:22: warning: member 'str' of type 'const std::string &' (aka 'const basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:45:49: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:45:68: warning: parameter name 'q' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:46:2: warning: variable 'prev' of type 'color::shell_command' can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:49:3: warning: variable 'c' of type 'boost::uint8_t' (aka 'unsigned char') can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:49:18: warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:49:22: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:51:4: warning: variable 'old' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:53:10: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:62:8: warning: accessing fields in struct 'if_not_empty' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 16 bytes [altera-struct-pack-align] -innoextract/src/util/output.hpp:64:22: warning: member 'name' of type 'const std::string &' (aka 'const basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:65:22: warning: member 'value' of type 'const std::string &' (aka 'const basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:67:15: warning: 2 adjacent parameters of 'if_not_empty' of similar type ('const std::string &') are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/util/output.hpp:72:49: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:72:74: warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:73:24: warning: 100 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:74:3: warning: variable 'prev' of type 'color::shell_command' can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:77:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/util/output.hpp:89:22: warning: member 'name' of type 'const std::string &' (aka 'const basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:90:10: warning: member 'value' of type 'const T' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:91:10: warning: member 'excluded' of type 'const T' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/output.hpp:93:36: warning: 2 adjacent parameters of 'if_not' of similar type ('T') are easily swapped by mistake [bugprone-easily-swappable-parameters] -innoextract/src/util/output.hpp:99:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:99:64: warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:103:4: warning: do not use 'else' after 'return' [readability-else-after-return] -innoextract/src/util/output.hpp:130:36: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:131:36: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:136:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:136:67: warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:138:2: warning: variable 'old' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:146:8: warning: accessing fields in struct 'print_hex_string' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 16 bytes [altera-struct-pack-align] -innoextract/src/util/output.hpp:155:49: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:155:78: warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:157:2: warning: variable 'old' of type 'std::ios_base::fmtflags' (aka 'std::_Ios_Fmtflags') can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:158:2: warning: variable 'oldfill' of type 'char' can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:162:25: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:162:29: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:200:8: warning: accessing fields in struct 'print_bytes' is inefficient due to poor alignment; currently aligned to 4 bytes, but recommended alignment is 8 bytes [altera-struct-pack-align] -innoextract/src/util/output.hpp:200:8: warning: accessing fields in struct 'print_bytes' is inefficient due to poor alignment; currently aligned to 8 bytes, but recommended alignment is 16 bytes [altera-struct-pack-align] -innoextract/src/util/output.hpp:207:38: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:208:38: warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:213:42: warning: parameter name 'os' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:213:69: warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:215:16: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:215:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:215:23: warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:215:41: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:215:41: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:215:43: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:215:43: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:216:26: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:216:26: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:218:9: warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/output.hpp:220:17: warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:220:29: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/output.hpp:221:18: warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:221:33: warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:225:15: warning: 100 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:225:53: warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:228:3: warning: variable 'num' of type 'float' can be declared 'const' [misc-const-correctness] -innoextract/src/util/output.hpp:228:15: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:228:31: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/output.hpp:228:45: warning: 1024.f is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/output.hpp:229:3: warning: variable 'old_precision' of type 'std::streamsize' (aka 'long') can be declared 'const' [misc-const-correctness] -innoextract/src/util/process.cpp:136:17: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast] +innoextract/src/util/process.cpp:23:1: warning: included header sstream is not used directly [misc-include-cleaner] +innoextract/src/util/process.cpp:69:1: warning: included header encoding.hpp is not used directly [misc-include-cleaner] +innoextract/src/util/process.cpp:136:17: warning: do not use const_cast to remove const qualifier [cppcoreguidelines-pro-type-const-cast] +innoextract/src/util/process.cpp:138:2: warning: no header providing "pid_t" is directly included [misc-include-cleaner] +innoextract/src/util/process.cpp:145:36: warning: no header providing "NULL" is directly included [misc-include-cleaner] +innoextract/src/util/process.cpp:170:5: warning: no header providing "WIFEXITED" is directly included [misc-include-cleaner] +innoextract/src/util/process.cpp:170:26: warning: no header providing "WEXITSTATUS" is directly included [misc-include-cleaner] +innoextract/src/util/process.cpp:172:12: warning: no header providing "WIFSIGNALED" is directly included [misc-include-cleaner] +innoextract/src/util/process.cpp:173:11: warning: no header providing "WTERMSIG" is directly included [misc-include-cleaner] -innoextract/src/util/storedenum.hpp:77:38: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/storedenum.hpp:99:41: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:113:42: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/storedenum.hpp:117:31: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:129:79: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] -innoextract/src/util/storedenum.hpp:129:79: warning: redundant cast to the same type [google-readability-casting] -innoextract/src/util/storedenum.hpp:130:15: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/storedenum.hpp:136:2: warning: 'operator bitset' must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] -innoextract/src/util/storedenum.hpp:156:43: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:165:39: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/storedenum.hpp:174:19: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/storedenum.hpp:176:19: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/storedenum.hpp:205:15: warning: member 'pad_bits' of type 'const size_t' (aka 'const unsigned long') is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/storedenum.hpp:207:17: warning: member 'stream' of type 'std::istream &' (aka 'basic_istream &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members] -innoextract/src/util/storedenum.hpp:221:45: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/storedenum.hpp:221:71: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:232:16: warning: C-style casts are discouraged; use static_cast [google-readability-casting] -innoextract/src/util/storedenum.hpp:239:2: warning: 'operator flags::value>' must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor] -innoextract/src/util/storedenum.hpp:240:32: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:254:45: warning: parameter name 'is' is too short, expected at least 3 characters [readability-identifier-length] -innoextract/src/util/storedenum.hpp:254:71: warning: 32 is a magic number; consider replacing it with a named constant [readability-magic-numbers] -innoextract/src/util/storedenum.hpp:259:25: warning: 256 is a magic number; consider replacing it with a named constant [readability-magic-numbers] +innoextract/src/util/time.cpp:103:22: warning: no header providing "std::tm" is directly included [misc-include-cleaner] -innoextract/src/util/time.cpp:153:13: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] -innoextract/src/util/time.cpp:155:5: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] +innoextract/src/util/time.cpp:192:2: warning: the value returned by this function should not be disregarded; neglecting it may lead to errors [cert-err33-c] +innoextract/src/util/time.cpp:223:14: warning: no header providing "std::mktime" is directly included [misc-include-cleaner] +innoextract/src/util/time.cpp:227:30: warning: no header providing "std::string" is directly included [misc-include-cleaner] +innoextract/src/util/time.cpp:262:45: warning: no header providing "boost::filesystem::path" is directly included [misc-include-cleaner] +clang-tidy: /mnt/overflow/var/tmp/portage/sys-devel/llvm-dev-9999/work/llvm-dev-9999/clang/include/clang/Basic/SourceManager.h:505: const clang::SrcMgr::ExpansionInfo& clang::SrcMgr::SLocEntry::getExpansion() const: Assertion `isExpansion() && "Not a macro expansion SLocEntry!"' failed.