-innoextract/src/cli/extract.cpp:1113:24: style: Variable 'location' can be declared as reference to const [constVariable] +innoextract/src/cli/extract.cpp:1113:24: style: Variable 'location' can be declared as reference to const [constVariableReference] -innoextract/src/cli/goggalaxy.cpp:228:68: style: Parameter 'constraints' can be declared as reference to const [constParameter] +innoextract/src/cli/goggalaxy.cpp:228:68: style: Parameter 'constraints' can be declared as reference to const [constParameterReference] -innoextract/src/loader/exereader.cpp:363:15: error: Signed integer overflow for expression '1<<31'. [integerOverflow] +innoextract/src/loader/exereader.cpp:172:17: warning: The struct 'ne_reader' defines member function with name 'get_file_version' also defined in its parent class 'exe_reader'. [duplInheritedMember] +innoextract/src/loader/exereader.cpp:189:17: warning: The struct 'le_reader' defines member function with name 'get_file_version' also defined in its parent class 'exe_reader'. [duplInheritedMember] +innoextract/src/loader/exereader.cpp:409:32: warning: The struct 'pe_reader' defines member function with name 'find_resource' also defined in its parent class 'exe_reader'. [duplInheritedMember] +innoextract/src/loader/exereader.cpp:469:17: warning: The struct 'pe_reader' defines member function with name 'get_file_version' also defined in its parent class 'exe_reader'. [duplInheritedMember] -innoextract/src/setup/info.cpp:53:56: performance: Function parameter 'entries' should be passed by const reference. [passedByValue] -innoextract/src/setup/info.cpp:73:78: performance: Function parameter 'entries' should be passed by const reference. [passedByValue] -innoextract/src/setup/info.cpp:98:73: performance: Function parameter 'entries' should be passed by const reference. [passedByValue] -innoextract/src/setup/task.hpp:72:1: error: The one definition rule is violated, different classes/structs have the same name 'enum_names < get_enum < :: flags < flags_Enum_ , flags_End_ > > :: type >' [ctuOneDefinitionRuleViolation] -innoextract/src/setup/version.hpp:65:36: performance: Function parameter 'type' should be passed by const reference. [passedByValue] -innoextract/src/setup/version.hpp:70:16: performance: Function parameter 'type' should be passed by const reference. [passedByValue] +innoextract/src/stream/exefilter.hpp:177:9: style: Variable 'end' can be declared as pointer to const [constVariablePointer] +innoextract/src/stream/lzma.cpp:87:36: warning: The class 'inno_lzma1_decompressor_impl' defines member function with name 'filter' also defined in its parent class 'lzma_decompressor_impl_base'. [duplInheritedMember] +innoextract/src/stream/lzma.cpp:119:36: warning: The class 'inno_lzma2_decompressor_impl' defines member function with name 'filter' also defined in its parent class 'lzma_decompressor_impl_base'. [duplInheritedMember] +innoextract/src/stream/lzma.hpp:83:7: warning: The class 'inno_lzma1_decompressor_impl' defines member function with name 'filter' also defined in its parent class 'lzma_decompressor_impl_base'. [duplInheritedMember] +innoextract/src/stream/lzma.hpp:86:7: warning: The class 'inno_lzma1_decompressor_impl' defines member function with name 'close' also defined in its parent class 'lzma_decompressor_impl_base'. [duplInheritedMember] +innoextract/src/stream/lzma.hpp:99:7: warning: The class 'inno_lzma2_decompressor_impl' defines member function with name 'filter' also defined in its parent class 'lzma_decompressor_impl_base'. [duplInheritedMember] +innoextract/src/util/console.cpp:103:10: style: Variable 'term' can be declared as pointer to const [constVariablePointer] -innoextract/src/util/endian.hpp:213:48: style: Condition '*reinterpret_cast(&signature)==1' is always false [knownConditionTrueFalse] -innoextract/src/util/endian.hpp:218:48: style: Condition '*reinterpret_cast(&signature)==4' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:213:48: style: Return value '*reinterpret_cast(&signature)==1' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:218:48: style: Return value '*reinterpret_cast(&signature)==4' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:228:56: style: Return value 'detail::is_little_endian()' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:232:55: style: Return value 'detail::is_big_endian()' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:257:53: style: Return value 'detail::is_big_endian()' is always false [knownConditionTrueFalse] +innoextract/src/util/endian.hpp:261:58: style: Return value 'detail::is_little_endian()' is always false [knownConditionTrueFalse] +innoextract/src/util/flags.hpp:78:20: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:86:24: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:90:24: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:110:24: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:114:24: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:118:24: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:127:27: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:132:27: performance: Function parameter 'o' should be passed by const reference. [passedByValue] +innoextract/src/util/time.cpp:136:9: style: Variable 'tz' can be declared as pointer to const [constVariablePointer] +innoextract/src/util/time.cpp:199:12: style: Variable 'tmp' can be declared as pointer to const [constVariablePointer] +innoextract/src/util/windows.cpp:237:7: warning: The class 'windows_console_sink' defines member function with name 'handle_command' also defined in its parent class 'ansi_console_parser < windows_console_sink >'. [duplInheritedMember] +innoextract/src/util/windows.cpp:360:7: warning: The class 'windows_console_sink' defines member function with name 'handle_text' also defined in its parent class 'ansi_console_parser < windows_console_sink >'. [duplInheritedMember]