+innoextract/src/cli/debug.cpp:390:19: style: Condition 'entry.options&setup::data_entry::VersionInfoValid' is always false [knownConditionTrueFalse] -[innoextract/src/cli/extract.cpp:386]: (style) Condition '!prompt_overwrite()' is always false -[innoextract/src/cli/extract.cpp:421]: (style) Condition '!prompt_overwrite()' is always false -[innoextract/src/cli/extract.cpp:428]: (style) Condition '!prompt_overwrite()' is always false -[innoextract/src/cli/extract.cpp:434]: (style) Condition '!prompt_overwrite()' is always false +innoextract/src/cli/extract.cpp:382:22: style: Condition 'olddata.options&setup::data_entry::VersionInfoValid' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:386:65: style: Condition '!prompt_overwrite()' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:404:13: style: Condition 'version_info_valid' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:421:64: style: Condition '!prompt_overwrite()' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:428:22: style: Condition 'newfile.options&setup::file_entry::ConfirmOverwrite' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:428:64: style: Condition '!prompt_overwrite()' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:434:67: style: Condition '!prompt_overwrite()' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:1182:16: style: Condition 'size!=0' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:1188:11: style: Condition 'checksum' is always false [knownConditionTrueFalse] +innoextract/src/cli/extract.cpp:1193:10: style: Condition 'named' is always false [knownConditionTrueFalse] -[innoextract/src/cli/extract.hpp:94]: (warning) Member variable 'extract_options::dump_headers' is not initialized in the constructor. +innoextract/src/cli/extract.hpp:94:2: warning: Member variable 'extract_options::dump_headers' is not initialized in the constructor. [uninitMemberVar] +innoextract/src/cli/goggalaxy.cpp:228:68: style: Parameter 'constraints' can be declared with const [constParameter] +innoextract/src/cli/goggalaxy.cpp:234:6: style: Condition '!result.empty()' is always false [knownConditionTrueFalse] +innoextract/src/cli/goggalaxy.cpp:278:23: style: Condition 'remaining_parts!=0' is always false [knownConditionTrueFalse] +innoextract/src/cli/goggalaxy.cpp:279:53: error: Null pointer dereference: file_start [nullPointer] -[innoextract/src/crypto/arc4.hpp:40]: (style) The struct 'arc4' does not have a constructor although it has private member variables. +innoextract/src/crypto/arc4.hpp:40:1: style: The struct 'arc4' does not have a constructor although it has private member variables. [noConstructor] -[innoextract/src/crypto/iteratedhash.hpp:45]: (style) The class 'iterated_hash' does not have a constructor although it has private member variables. +innoextract/src/crypto/iteratedhash.hpp:45:1: style: The class 'iterated_hash' does not have a constructor although it has private member variables. [noConstructor] -[innoextract/src/loader/exereader.cpp:363]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour +innoextract/src/loader/exereader.cpp:363:15: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] -[innoextract/src/setup/component.hpp:77]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/data.hpp:88]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/directory.hpp:67]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/expression.cpp:59]: (warning) Member variable 'evaluator::token_length' is not initialized in the constructor. -[innoextract/src/setup/expression.cpp:59]: (warning) Member variable 'evaluator::token_start' is not initialized in the constructor. +innoextract/src/setup/expression.cpp:59:2: warning: Member variable 'evaluator::token_length' is not initialized in the constructor. [uninitMemberVar] +innoextract/src/setup/expression.cpp:59:2: warning: Member variable 'evaluator::token_start' is not initialized in the constructor. [uninitMemberVar] -[innoextract/src/setup/file.hpp:122]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/header.hpp:288]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/icon.hpp:87]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/info.cpp:73]: (performance) Function parameter 'entries' should be passed by const reference. -[innoextract/src/setup/info.cpp:98]: (performance) Function parameter 'entries' should be passed by const reference. -[innoextract/src/setup/info.cpp:317]: (warning) Member variable 'info::header' is not initialized in the constructor. +innoextract/src/setup/info.cpp:73:78: performance: Function parameter 'entries' should be passed by const reference. [passedByValue] +innoextract/src/setup/info.cpp:98:73: performance: Function parameter 'entries' should be passed by const reference. [passedByValue] +innoextract/src/setup/info.cpp:317:7: warning: Member variable 'info::header' is not initialized in the constructor. [uninitMemberVar] -[innoextract/src/setup/ini.hpp:63]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/registry.hpp:99]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/run.hpp:82]: (performance) Function parameter 'b' should be passed by const reference. -[innoextract/src/setup/task.hpp:72]: (performance) Function parameter 'b' should be passed by const reference. +innoextract/src/setup/version.cpp:219:23: note: Assuming that condition 'legacy_version[0]=='i'' is not redundant +innoextract/src/setup/version.cpp:234:24: note: Condition 'legacy_version[0]!='i'' is always false +innoextract/src/setup/version.cpp:234:24: style: Condition 'legacy_version[0]!='i'' is always false [knownConditionTrueFalse] -[innoextract/src/setup/version.hpp:65]: (performance) Function parameter 'type' should be passed by const reference. -[innoextract/src/setup/version.hpp:70]: (performance) Function parameter 'type' should be passed by const reference. +innoextract/src/setup/version.hpp:65:36: performance: Function parameter 'type' should be passed by const reference. [passedByValue] +innoextract/src/setup/version.hpp:70:16: performance: Function parameter 'type' should be passed by const reference. [passedByValue] +innoextract/src/setup/version.hpp:80:49: style: Condition 'variant&Bits16' is always false [knownConditionTrueFalse] -[innoextract/src/stream/block.cpp:79]: (warning) Member variable 'inno_block_filter::buffer' is not initialized in the constructor. +innoextract/src/stream/block.cpp:79:2: warning: Member variable 'inno_block_filter::buffer' is not initialized in the constructor. [uninitMemberVar] -[innoextract/src/stream/exefilter.hpp:59]: (warning) Member variable 'inno_exe_decoder_4108::addr_bytes_left' is not initialized in the constructor. +innoextract/src/stream/exefilter.hpp:59:2: warning: Member variable 'inno_exe_decoder_4108::addr_bytes_left' is not initialized in the constructor. [uninitMemberVar] -[innoextract/src/stream/lzma.hpp:81]: (warning) Member variable 'inno_lzma1_decompressor_impl::header' is not initialized in the constructor. +innoextract/src/stream/lzma.hpp:81:2: warning: Member variable 'inno_lzma1_decompressor_impl::header' is not initialized in the constructor. [uninitMemberVar] -[innoextract/src/util/console.cpp:102]: (style) Condition 'is_tty' is always false -[innoextract/src/util/console.cpp:126]: (style) Condition '!is_tty' is always true +innoextract/src/util/console.cpp:102:5: style: Condition 'is_tty' is always false [knownConditionTrueFalse] +innoextract/src/util/console.cpp:126:49: style: Condition '!is_tty' is always true [knownConditionTrueFalse] -[innoextract/src/util/encoding.cpp:684]: (error) Invalid pointer 'outbuf' after push_back(). -[innoextract/src/util/flags.hpp:60]: (performance) Function parameter 'flag' should be passed by const reference. -[innoextract/src/util/flags.hpp:169]: (performance) Function parameter 'b' should be passed by const reference. +innoextract/src/util/flags.hpp:60:22: performance: Function parameter 'flag' should be passed by const reference. [passedByValue] +innoextract/src/util/flags.hpp:169:55: performance: Function parameter 'b' should be passed by const reference. [passedByValue] -[innoextract/src/util/storedenum.hpp:225]: (performance) Function parameter 'flag' should be passed by const reference. -[innoextract/src/util/time.cpp:258]: (error) syntax error: "C" typedef